There are many forms of Zionism and they're all bad

Some say "I'm a proud Zionist." And some say, "I'm not a Zionist, but ...." If there's a but, there's a Zionist, and that means there's a problem with their facts (or lack of them) and their understanding of the Torah. 

So you have the secular Zionists who have replaced being Jewish with being Israeli. Obviously, that's bad from an Orthodox Jewish perspective. These people have no conception of the Torah. They sin on the land, and that's bad. 

Then you have TO Jews who see the state as the beginning of geulah, even without teshuvah, without Moshiach, with 70 years of pain and death. These are delusional people who look neither at the world around them or the Torah. They just bend it according to their will. They run around telling everyone to move to Israel regardless of what it does to most people and their children.

Then you have those who wouldn't say that the state is geulah, but it's a good thing just the same. So they are not bothered by 4.5 million people violating the Sabbath and 3 million eating on Yom Kippur, by a million Sephardim dumping religion when coming to EY, by hundreds of thousands of gentiles from the former USSR mixing in with the population and calling itself Jewish. They don't care about those people. They want to be able to visit Israel (not that they couldn't have if there wasn't a state), a place that they also don't care about as it is stained from sin. They care only about themselves.

The yeshiva guy claims to distance himself from all this. He is critical of the government, mostly for its antireligious positions and its attempt to draft yeshiva bochurim, but he still might believe that the state was founded with miracles. This is Zionism too. Egypt sent 5,000 soldiers in '48. The Zionists always had the advantage. There was no threat of annihilation and no miracle. To see it as miraculous is to allow oneself to accept Zionist propaganda, which means he is not taking his direction from the Torah.

So too it is Zionistic to believe that the Arabs all want to annihilate Israel. It's Zionist propaganda. They have never tried, not in any war. The YK war in '73 was just an attempt to push Israel back a few miles from the Egyptian border. Israel attacked in '56 and '67, the latter occasion of which even Begin said Sadat was not going to attack. He was honoring a mutual defense pact with Syria and Israel had been pushing into the Golan. Israel attacked Lebanon because a few missiles had been sent to Israel, but that's not genocide or even an assault. 

Then you have the guys who hate the state but believe everyone must live in EY. I know a few characters like this. They don't realize that Hashem said, to me is all the land (of the world.) You can keep Torah anywhere, and you should keep it where you keep it best. These also are people who don't care about the mitzvos or people's lives. They like Israel, that's all. They are pushing the geulah, forcing the end. In a sense they are saying I don't like this government but I want to create my own and need you to move here to make it happen. It's still Zionism. It's forcing the end. This is a violation of halacha as described by the Rambam.

All of this is Zionism and it's all bad. It's all the result of Zionist propaganda and it all supports the atheism and rebellion in one way or another.